-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the crate version centrally via the workspace #2089
Conversation
b0d8f92
to
f0675a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer. I think the devtools/set_version.sh
also needs updating (or we just remove it and update the wiki page for publishing)
What happens to the internal versions that use |
Good point, we do need to keep the version script for those. |
Tbh the entire release process could be streamlined with It automatically:
|
Haven't used cargo-release before, but after trying it out, it looks pretty good. Switching to it would be fine from my side. It would also solve some edge cases the current script has. For example, the script could replace versions of unrelated dependencies that just happen to be the same as our old version. |
I'm gonna have a look at integrating it. Gonna do that in a separate PR Because having the entire release process in one, plus edge case avoidance, feels like a pretty worthwhile addition |
@chipshort Mind giving this a last quick look so we can merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The version script will be broken with this merged, but that will become irrelevant with #2090
No description provided.